search

facebook / buck2

Build system, successor to Buck
https://buck2.build/
Apache License 2.0
3.53k stars 215 forks source link

There is a need to correlate all requests to CAS,AC and Execution server in order to improve scheduling #503

Open vaskomitanov opened 10 months ago

vaskomitanov commented 10 months ago

For context:

In an internal, large cluster running many workers where each worker has internal CAS and there is additional external CAS & AC, there is a need to correlate all buck RE requests with some identifier. Using such identifier, it is easier to maintain consistency between cluster worker nodes and to improve cache locality.

For this purpose, I've added the build-info inside binary metadata field. Since this change expands the proto something that is Meta's internal and may break thing at Meta, please let me know and I can move this value into a separate metadata header (as an Ascii metadata).

https://github.com/facebook/buck2/pull/502

ndmitchell commented 10 months ago

Thanks for the PR, let's follow up discussions there.