facebook / buck2

Build system, successor to Buck
https://buck2.build/
Apache License 2.0
3.53k stars 215 forks source link

Added example using Buck with Visual Studio Code on Windows #517

Closed Overhatted closed 7 months ago

Overhatted commented 9 months ago
  1. I made the default platform in the prelude public so it can be inherited from. I don't know why it wasn't already like that. Maybe I'm misunderstanding how to use it
  2. Not sure if I'm using the config_setting and constraint_setting properly since it seems duplicated.
  3. The script to generate the compile_commands.json was more or less copied from #510.

There are still a lot of improvements to be made but I think this is good enough to be merged:

  1. With MSVC the compilation should probably be done with /Z7 by default and then, if the "stripped" sub-target is asked for, that flag is removed.
  2. The cxx toolchain needs the compilation options looked at, not sure if Linux's defaults work properly.
  3. The Install.ps1 and Copy.ps1 need to be ported to Linux.
ndmitchell commented 9 months ago

Thanks! I think our bar for samples is relatively low (if this is what you want to do, its super helpful to get started) so would be happy to get this included.

Overhatted commented 9 months ago

Now I think it's ready for merging. Let me know why the "Meta Import Checks" is failing and what I can do to fix it.

Overhatted commented 7 months ago

Hello @ndmitchell, can you let me know why the "Meta Import Checks" fails? Is it the .vscode files?

JakobDegen commented 7 months ago

@Overhatted yes, that is why. I'll get that fixed, in the meantime I'm trying to see if I can get someone on the windows side internally to review this, otherwise Neil is right that the bar for examples is fairly low and we can just get this merged

facebook-github-bot commented 7 months ago

@JakobDegen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 7 months ago

@JakobDegen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.