Closed Overhatted closed 7 months ago
Thanks! I think our bar for samples is relatively low (if this is what you want to do, its super helpful to get started) so would be happy to get this included.
Now I think it's ready for merging. Let me know why the "Meta Import Checks" is failing and what I can do to fix it.
Hello @ndmitchell, can you let me know why the "Meta Import Checks" fails? Is it the .vscode files?
@Overhatted yes, that is why. I'll get that fixed, in the meantime I'm trying to see if I can get someone on the windows side internally to review this, otherwise Neil is right that the bar for examples is fairly low and we can just get this merged
@JakobDegen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@JakobDegen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
There are still a lot of improvements to be made but I think this is good enough to be merged: