facebook / buck2

Build system, successor to Buck
https://buck2.build/
Apache License 2.0
3.38k stars 200 forks source link

Add build and test jobs for linux, macos, and windows #542

Closed robandpdx closed 5 months ago

robandpdx commented 5 months ago

This pull request adds the following jobs to the github actions workflow:

linux-build-and-test
macos-build-and-test
windows-build-and-test

The linux-build-and-test requires a larger runner, else it will fail with the following error:

= note: /usr/bin/ld: final link failed: No space left on device
collect2: error: ld returned 1 exit status

The following runner group is needed:

For my testing, I have these runner groups populated with the following runners: Group Runner size OS
4-core-ubuntu 4-cores · 16 GB RAM · 150 GB SSD Ubuntu Latest

View the latest workflow run in my fork here.

https://fburl.com/workplace/f6mz6tmw

robandpdx commented 5 months ago

Maybe we want the linux job in a separate PR, due to it's need for a larger runner. If so, let me know and I'll make it happen.

facebook-github-bot commented 5 months ago

@shayne-fletcher has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

shayne-fletcher commented 5 months ago

@robandpdx merged. thanks!