Closed jrmolin closed 2 months ago
Hi @jrmolin!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
if https://github.com/facebook/buck2/pull/581 gets merged, I'll need to make some edits.
@jrmolin Yes, you need to rebase. I tried to make it more compatible with your change.
@KapJI has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Microsoft releases an Enterprise WDK (EWDK) bundle for building drivers and applications without needing a Visual Studio installation. This is very useful for CI builds, where unpacking a zip or mounting an iso file is all that is needed to spin up a build VM, instead of needing to download, install, validate, install WDK, install SDK, repair WDK, etc. Also, there is no license requirement to use the EWDK.
This updates the
vswhere.py
file to extract the necessary binaries, include dirs, and library dirs from the environment produced by calling theSetupBuildEnv.bat
utility in the EWDK. Once this is done, the rest of a buck2 build operates normally.To use this, download and "install" the EWDK to the filesystem.