facebook / buck2

Build system, successor to Buck
https://buck2.build/
Apache License 2.0
3.33k stars 194 forks source link

remove clang pinning functions #598

Closed bunnypak closed 2 months ago

bunnypak commented 2 months ago

Summary: X-link: https://github.com/pytorch/executorch/pull/2326

Removing clang pinning functions because it's replaced by config modifiers, e.g. fbcode/scripts/zpak/examples/PACKAGE

load("fbcode_macros//build_defs:platform_modifiers.bzl", "platform_modifiers")
load(
    "fbcode//buck2/cfg/experimental/set_cfg_modifiers.bzl",
    "set_cfg_modifiers",
)

modifiers = []

modifiers += platform_modifiers.fbcode_platform("platform010-compat")

modifiers += platform_modifiers.fbcode_clang("15")

set_cfg_modifiers(cfg_modifiers = modifiers)

Reviewed By: dmm-fb

Differential Revision: D54681702

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D54681702

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D54681702

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D54681702

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D54681702