toolchains: Allow overriding all toolchain attrs

facebook / buck2

Build system, successor to Buck

https://buck2.build/

Apache License 2.0

3.33k stars 194 forks source link

toolchains: Allow overriding all toolchain attrs #618

Closed JakobDegen closed 1 month ago

JakobDegen commented 1 month ago

Summary: We already allowed this for a couple languages, let's extend it to all of them.

I don't see what we get by banning this, and there are clearly use cases for allowing it. Also, an open source user just needed this for the CXX toolchain.

Differential Revision: D56048492

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D56048492

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D56048492