facebook / buck2

Build system, successor to Buck
https://buck2.build/
Apache License 2.0
3.33k stars 194 forks source link

Move to TSets #624

Closed ndmitchell closed 3 weeks ago

ndmitchell commented 4 weeks ago

Summary: Apply D56345659 and D56241179 (which were reverted in D56364484) along with performance optimisations on the fact that multiple packages might exist within the same package_db. Before, since we deduplicated everything by value, you might have 100 packages and 20 package_dbs. If you give GHC 100 package dbs (even if there are only 20 unique ones) the performance crashes dramatically. That's especially true if you have a package_db representing all of stackage, which both occurs a lot and is slow to load. The two places are:

Differential Revision: D56378115

facebook-github-bot commented 4 weeks ago

This pull request was exported from Phabricator. Differential Revision: D56378115