Closed ejnguyen closed 2 weeks ago
Summary: Right now, we rely on the sys_info library to get the OS version.
However, that functionality is broken for Windows: https://github.com/FillZpp/sys-info-rs/issues/86 Specifically, it produces 6.2.9200 for all versions across Windows: https://fburl.com/scuba/buck2_builds/iq6hsudp
6.2.9200
This diff swaps the check to use the winver library, which has much better support for fetching the Windows version.
Reviewed By: JakobDegen
Differential Revision: D56546196
Summary: Right now, we rely on the sys_info library to get the OS version.
However, that functionality is broken for Windows: https://github.com/FillZpp/sys-info-rs/issues/86 Specifically, it produces
6.2.9200for all versions across Windows: https://fburl.com/scuba/buck2_builds/iq6hsudpThis diff swaps the check to use the winver library, which has much better support for fetching the Windows version.
Reviewed By: JakobDegen
Differential Revision: D56546196