search

facebook / buck2

Build system, successor to Buck
https://buck2.build/
Apache License 2.0
3.33k stars 194 forks source link

`zip_file` prelude rule partially exported #637

Open benbrittain opened 2 weeks ago

benbrittain commented 2 weeks ago

The prelude rule for zip_file looks like it's been partially exported.

It looks like the toolchain target that is used internal to Meta is called fbsource//xplat/buck2/platform/zip_file:zip_file. I'm pretty sure the rule can't be used without it, the arguments don't refer to a zip tool I'm aware of. I'd guess it's a python wrapper around the zip tool itself.

JakobDegen commented 1 week ago

The tool that our toolchain points to is this one. I could hypothetically copy that into the prelude and claim that you're now better supported, but that would require a bootstrap java toolchain or something like that which is a road I really don't think we want to go down in the prelude. You of course still have the option to do that in your own repo if you like.

Probably someone should rewrite that thing into python (or even better, modify the rule to just accept a standard zip tool).

benbrittain commented 2 days ago

Probably the zip rules should be removed then? They are just kinda api noise for open source if they aren't functional.