Open valadez-abel opened 5 months ago
@valadez-abel do you have a self-contained repro for this issue? I'm asking because internally at Meta we're using these rules with RE quite successfully, and so I'd like to understand what the difference is
I don't currently have a self contained repro for this. I can try to create one using zig (won't be able to package vs / windows sdk), as I'm hitting this as soon as the prelude / shell scripts to run the python kicks in, so any cpp file should do the trick. Give me a few days, though I highly suspect that there's a combination in play due to how Engflow's RE is setup vs how Meta's is setup.
Even after bypassing #673, symbolic links are not properly getting propagated to the remote execution executors for windows:
Changing: https://github.com/facebook/buck2/blob/2214ec241cefe357faf499e30b26629ce6728c8c/prelude/sh_binary.bzl#L38 to use copied_dirs bypasses the problem.
Happy to provide a fix for this, as well as #673