Make fb_sysctl work under chef12

[chantra]

Without that FB::FBSysctl.sysctl_in_sync? was not found. Pretty much #dogsciencing this

[jaymzh]

What? this works just fine in 12... all classes in libraries are available in the recipe DSL.

[chantra]

Well, this is what happen when using it from a recipe that has the following content: include_recipe 'fb_sysctl' node.default['fb']['fb_sysctl']['net.ipv4.tcp_syncookies'] = '1'

https://gist.github.com/chantra/ca72f12880cd270e93c1

[jaymzh]

OK, so we didn't namespace it in the internal version. Let me try to get our internal in sync with this and test again.

[jaymzh]

OK, I can repro this. Can you instead do this:

• Change def sysctl_in_sync? to def self.sysctl_in_sync?(node)
• Change the call site to FB::Sysctl.sysctl_in_sync?(node)

You won't need the send at that point, it'll all just work.

Thanks.

[jaymzh]

(I'm also happy to do my own PR for that if you prefer, but I figured you'd rather do it)

[chantra]

@jaymzh yeah, I am good doing it.

[jaymzh]

Thanks!