facebook / chisel

Chisel is a collection of LLDB commands to assist debugging iOS apps.
MIT License
9.13k stars 803 forks source link

Improve findinstances handling of Swift subclasses #219

Closed kastiglione closed 6 years ago

kastiglione commented 6 years ago

Calling findinstances currently requires the exact class name. For classes implemented in Swift, the name includes the module name, for example SuperKit.DuperClass. This change allows findinstances to be called with simply the class name (DuperClass in the previous example).

Note: This change does handle the case where more than one module contains a class by that name. For example, if two modules each define a class named User, then running findinstances User will list instances of both classes.

This pull request also includes a few other small improvements.

keith commented 6 years ago

Super nice improvement!