facebook / chisel

Chisel is a collection of LLDB commands to assist debugging iOS apps.
MIT License
9.13k stars 803 forks source link

Fix how sequence handles initial commands #234

Closed kastiglione closed 6 years ago

kastiglione commented 6 years ago

This initial version of sequence #233 would only print the output from the last command, because it reused the same SBCommandReturnObject for each command, which doesn't work due lldb calling Clear() within HandleCommand.

With this change, a fresh SBCommandReturnObject is used for each given command. If this temporary return object has output, it is appended to the main result object (self.result). If the command doesn't succeed, the error and status of the failed result are copied to the main self.result.