RFC: Render Method in ComponentKit - Githubissues

facebook / componentkit

A React-inspired view framework for iOS.

http://www.componentkit.org/

Other

5.76k stars 587 forks source link

RFC: Render Method in ComponentKit #898

Closed kfirapps closed 6 years ago

kfirapps commented 6 years ago

Component Tree Creation
- After the root component's creation in CKBuildComponent(..), the infra creates a component tree (CKComponentTreeNode) recursively with the new render method. CKComponentTreeNode is the equivalent of CKComponentScopeFrame; but the main difference is that every component has one.
State
- Instead of accessing the state from a scope, the infra will pass it down to the render method.
- No need for scopes anymore
Changes in CKComponent classes
- CKSingleChildComponent
  - Introduce a new a component type that has a render method: - (CKComponent *)render:(id)state. The default implementation returns {}.
- CKGroupComponent
  - Introduce a new a component type that has a renderGroup method: - (std::vector<CKComponent *>)renderGroup:(id)state. The default implementation returns {}.
- CKFlexboxComponent
  - Subclass from CKGroupComponent
  - Override the render method and map from {CKFlexboxChild} → {CKComponent}

ocrickard commented 6 years ago

Very cool! I think it might be worth taking a pass to reduce the boilerplate if that's possible.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

ocrickard commented 6 years ago

@eczarny may have some opinions as well. He was deeply involved in my proposals around typed props.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

facebook-github-bot commented 6 years ago

@kfirapps has updated the pull request.

kfirapps commented 6 years ago

We will review this change internally and sync it to the open source later.