search

facebook / create-react-app

Set up a modern web app by running one command.
https://create-react-app.dev
MIT License
102.73k stars 26.85k forks source link

Babel loader does not seem to handle numeric separators in external packages #11494

Open l-monninger opened 3 years ago

l-monninger commented 3 years ago

Describe the bug

The babel loader used with run does not appear to handle numeric separators in 4.0.3. I have not tested other versions.

Did you try recovering your dependencies?

Yes.

Which terms did you search for in User Guide?

Yes.

Environment

react-scripts 4.0.03 node v14.17.4 typescript 4.2.4

Steps to reproduce

  1. Create React App.
  2. Add module that uses numeric separators (color 4.0.1 for example)
  3. Attempt to import module that uses numeric separators.
  4. react-scripts run

Expected behavior

The app compiles and runs.

Actual behavior

The app does not compile.

Reproducible demo

https://github.com/l-monninger/react-scripts-numeric-separators-demo

nrayburn-tech commented 3 years ago

Same as https://github.com/facebook/create-react-app/issues/11339.

l-monninger commented 3 years ago

@nrayburn-tech is this the recommendation just to eject for now?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.