search

facebook / create-react-app

Set up a modern web app by running one command.
https://create-react-app.dev
MIT License
102.76k stars 26.87k forks source link

Update sass-loader to 12.4.0 to support node-sass 7.0.0 #11726

Open p-young opened 2 years ago

p-young commented 2 years ago

Describe the bug

Currently, an error is given when trying to use node-sass 7.0.0: ./src/index.scss (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-6-1!./node_modules/postcss-loader/src??postcss!./node_modules/resolve-url-loader??ref--5-oneOf-6-3!./node_modules/sass-loader/dist/cjs.js??ref--5-oneOf-6-4!./src/index.scss) Node Sass version 7.0.0 is incompatible with ^4.0.0 || ^5.0.0 || ^6.0.0.

node-sass is still useful because sass (dart-sass) is slower

sass-loader was just updated to 12.4.0 today to support node-sass 7.0.0 (also a recent update).

It would be nice to have this! Thanks

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

alkismavridis commented 2 years ago

Also affected

JustFly1984 commented 2 years ago

node-sass@7 is deprecated and has security vulnerabilities. recommended to switch to npm sass which is currently maintained.

Li1506 commented 1 year ago

sass-loader now is on version 13.x and depends on node-sass v8, the version removes deprecated request dependency.

will be good to upgrade sass-loader v13.