facebook / create-react-app

Set up a modern web app by running one command.
https://create-react-app.dev
MIT License
102.22k stars 26.68k forks source link

Custom react template throws an error that module cannot be found #12610

Open tylers-username opened 1 year ago

tylers-username commented 1 year ago

Discussed in https://github.com/facebook/create-react-app/discussions/12609

Originally posted by **tylerssn** July 23, 2022 Trying to create a custom template and getting an error when testing ``` $ create-react-app --version 5.0.1 $ create-react-app temporary --template file:../../cra-template-mine ... Error: Cannot find module 'file:/Users/me/Code//package.json' Require stack: - /Users/me/Code/@platform/create-react-app-platformsh/deleteme/node_modules/react-scripts/scripts/init.js - /Users/me/Code/@platform/create-react-app-platformsh/deleteme/[eval] at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15) at Function.resolve (internal/modules/cjs/helpers.js:99:19) at module.exports (/Users/me/Code/@platform/create-react-app-platformsh/deleteme/node_modules/react-scripts/scripts/init.js:117:13) at [eval]:3:14 at Script.runInThisContext (vm.js:134:12) at Object.runInThisContext (vm.js:310:38) at internal/process/execution.js:81:19 at [eval]-wrapper:6:22 at evalScript (internal/process/execution.js:80:60) at internal/main/eval_string.js:27:3 { code: 'MODULE_NOT_FOUND', requireStack: [ '/Users/me/Code/@platform/create-react-app-platformsh/deleteme/node_modules/react-scripts/scripts/init.js', '/Users/me/Code/@platform/create-react-app-platformsh/deleteme/[eval]' ] } Aborting installation. node has failed. Deleting generated file... node_modules Deleting generated file... package.json Done. ```
tylers-username commented 1 year ago

🤕 this is caused by having @ in the file path.

I commonly namespace directories with @company, @organization, etc...

tylers-username commented 1 year ago

Resolved by https://github.com/facebook/create-react-app/pull/12611