facebook / create-react-app

Set up a modern web app by running one command.
https://create-react-app.dev
MIT License
102.52k stars 26.77k forks source link

Remove link to Heroku tutorial + buildpack from docs #12800

Open psawaya opened 1 year ago

psawaya commented 1 year ago

On this page: https://create-react-app.dev/docs/deployment/

You link to this Heroku article: https://blog.heroku.com/deploying-react-with-zero-configuration

That article (from 2016) seems to be out-of-date. In particular, the buildpack it suggests using seems no longer supported on the latest Heroku stack. Here's what I saw when I attempted to use it:

remote: =====! create-react-app-buildpack has reached end-of-life šŸŒ…
remote:        This build may succeed, but the buildpack is no longer maintained.
remote:        On the Heroku-22 stack and beyond, this may fail to build at all.
remote: 
remote:        Please consider migrating to https://nextjs.org or https://remix.run to develop React apps which are deployable using Heroku's Node.js buildpack https://github.com/heroku/heroku-buildpack-nodejs, or you may develop your own create-react-app deployment with Node.js and Nginx buildpacks.
remote: 

And then later down:

emote: =====> Detected Framework: Static HTML
remote: Stack heroku-22 is not supported!
remote:  !     Push rejected, failed to compile React.js (create-react-app) multi app.
remote: 
remote:  !     Push failed
judycodes commented 1 year ago

hello, is anyone working on this? if not, i'd like to pick this up.

BraianS commented 5 months ago

Hello. Any update on this?