search

facebook / create-react-app

Set up a modern web app by running one command.
https://create-react-app.dev
MIT License
102.51k stars 26.77k forks source link

next@b2fd8db8 throws if monorepo with nwb modules #4249

Closed bebbi closed 5 years ago

bebbi commented 6 years ago

Is this a bug report?

yes.

I'm using the next branch with a monorepo including a cra app and a few nwb modules and am getting the following error:

Failed to compile.

../nwb-lib/es/index.js
/path/proj/packages/nwb-lib/es/index.js
  3:1  error  Import in body of module; reorder to top  import/first

See also https://github.com/insin/nwb/issues/450 @gaeron suggested to repost here.

Did you try recovering your dependencies?

yes

Which terms did you search for in User Guide?

n.a. I think

Environment

  1. node -v: 8.9.1
  2. npm -v: 5.7.1
  3. yarn --version (if you use Yarn): 1.5.1
  4. npm ls react-scripts (if you haven’t ejected):

Then, specify:

  1. Operating system: macos 10.13.4
  2. Browser and version (if relevant): n.a.

Steps to Reproduce

  1. Create a cra monorepo project
  2. with one package being a nwb component with an es build (web-module in my case if it matters)
  3. build the component and run the app

Expected Behavior

Should just run fine.

Actual Behavior

yarn start doesn't serve but instead shows the above error.

Reproducible Demo

I will try if this issue is not very straightforward.

gaearon commented 6 years ago

This sounds like the fix would be to wait for https://github.com/facebook/create-react-app/issues/4092.

bebbi commented 6 years ago

@gaearon not sure it is related, as the above nwb-lib is publishable and by definition of the referenced proposal it would still need its own build mechanism and be out of scope for source packages.

gaearon commented 6 years ago

🤔

In that case we should exclude "publishable" packages from linting.

bebbi commented 6 years ago

It might be useful to add "Cannot co-exist in a monorepo with publishable packages" to the known issues in #3815?

bradfordlemley commented 6 years ago

To summarize:

The current alpha implementation doesn't provide a mechanism to specify which packages in the monorepo should be built/linted -- if your app includes another package in the monorepo, it will be transpiled and linted. This leads to an incompatibility with nwb packages in the monorepo because the nwb-built output (es/index.js) fails to lint (because it has some functions defined at the top of the file, then imports can happen later on).

https://github.com/facebook/create-react-app/issues/4092 proposes a mechanism to specify which packages should be built/transpiled and their source entry points, so it will allow nwb packages to in the monorepo to be used by the app, either by not specifying them as source packages, or specifying their "source" entry point. However, it requires the source packages to be "private", which essentially prevents the app from utilizing nwb packages as source packages because there's almost no reason to use nwb unless you're going to publish your package.

bradfordlemley commented 6 years ago

@gaearon Would you be open to relaxing the "private" flag requirement if the package contains both "source" and "main" (or "browser", "module") entry points? This would allow publicly-published packages (like nwb packages) to be used as source packages, but also help ensure that any publicly-published packages conform to npm ecosystem standards.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

stale[bot] commented 5 years ago

This issue has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue.