One does not simple find the `--scripts-version` tag documentation

miraage commented 6 years ago

Search results for --scripts-version. We can see 6 occurences in the code. None of these files is README. Do you guys plan to remove this argument or maybe it just got lost in docs at some point?

Timer commented 6 years ago

It was probably lost in docs at some point or never documented.

https://github.com/facebook/create-react-app/blob/f80d27ba5b03385170c3584f91c2e160977c1f35/packages/create-react-app/createReactApp.js#L84-L93

miraage commented 6 years ago

@Timer Do you want me to open a PR to add a section in the "Creating an App" docs or we can just close this one?

Timer commented 6 years ago

I think the CLI help is enough. We don't want to encourage using old/different versions. Curious users who fork normally know about this.

miraage commented 6 years ago

Sounds legit. Closing this issue then. Thanks for clarifications.

jadbox commented 5 years ago

@Timer @miraage I think this broke Typescipt in the master branch:

npm notice === Tarball Details ===
npm notice name:          react-scripts
npm notice version:       2.0.5
npm notice filename:      react-scripts-2.0.5.tgz
npm notice package size:  40.3 kB
npm notice unpacked size: 153.1 kB
npm notice shasum:        34ef5ffe8ee7fd57f0533a83af140d151c224009
npm notice integrity:     sha512-UR7eY3N2ZrCfm[...]zPatzxdb22VFw==
npm notice total files:   45
npm notice

  error: unknown option `--scripts-version'

ERROR! An error was encountered while executing
{ Error: Command failed: node /Users/jdunlap/github/create-react-app/packages/create-react-app/index.js --scripts-version="/Users/jdunlap/github/create-react-app/packages/react-scripts/react-scripts-2.0.5.tgz" --typescript my-app --typescript
    at checkExecSyncError (child_process.js:575:11)
    at Object.execSync (child_process.js:612:13)
    at Object.<anonymous> (/Users/jdunlap/github/create-react-app/tasks/cra.js:115:4)
    at Module._compile (internal/modules/cjs/loader.js:654:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:665:10)
    at Module.load (internal/modules/cjs/loader.js:566:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:506:12)
    at Function.Module._load (internal/modules/cjs/loader.js:498:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:695:10)
    at startup (internal/bootstrap/node.js:201:19)
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 13671,
  stdout: null,
  stderr: null }
Cleaning up.
Exiting with error.

facebook / create-react-app

One does not simple find the `--scripts-version` tag documentation #5366