Open SethFalco opened 3 weeks ago
Built without sensitive environment variables
Name | Link |
---|---|
Latest commit | 6398ae8f11cc415583c41836ba4ca61b6dcf58f2 |
Latest deploy log | https://app.netlify.com/sites/docusaurus-2/deploys/66677a38a437600008bf777d |
Deploy Preview | https://deploy-preview-10211--docusaurus-2.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
URL | Performance | Accessibility | Best Practices | SEO | PWA | Report |
---|---|---|---|---|---|---|
/ | π 67 | π’ 98 | π’ 96 | π’ 100 | π 88 | Report |
/docs/installation | π 65 | π’ 96 | π’ 100 | π’ 100 | π 88 | Report |
/docs/category/getting-started | π 74 | π’ 100 | π’ 100 | π’ 90 | π 88 | Report |
/blog | π 70 | π’ 100 | π’ 100 | π’ 90 | π 88 | Report |
/blog/preparing-your-site-for-docusaurus-v3 | π 64 | π’ 96 | π’ 100 | π’ 100 | π 88 | Report |
/blog/tags/release | π 67 | π’ 100 | π’ 100 | π’ 90 | π 88 | Report |
/blog/tags | π 73 | π’ 100 | π’ 100 | π’ 90 | π 88 | Report |
Note: This is a draft! It does work, and all tests are passing, but I'm not very familiar with the repository and wary that I haven't handled loading files and applying them to the webpack configuration correctly. (Or if you're even ok with that approach!)
This is mostly intended to be a starting point, any feedback or mentorship would be appreciated! Once we're happy with the implementation and interface, I can introduce new tests and documentation.
Pre-flight checklist
Motivation
There have been discussions about introducing an easier way for users to configure SVGO. This is an attempt to expose it similarly to how SVGO itself and SVGR does.
svgo.config.js
(or.mjs
/.cjs
) file.svgo.config.js
file, thoughβ¦ based on the docs I don't know how. πThis PR makes it so if a
svgo.config.js
file is present in the site directory, it loads it instead of using what Docusaurus defines. If it is not present, Docusaurus uses a default config which is the same as before.Changes
loadFreshModule
is no longer async as it never called await internally anyway, this allowed me to use it ingetFileLoaderUtils
without much fuss.svgo.config.js
to the generated filesgetFileLoaderUtils
, readssvgo.config.js
from generated files and passes that config to SVGO.Test Plan
Test links
Before
This is how the dogfooding page looked originally, and still looks when no
svgo.config.js
file is present. Docusaurus defines a default config if one isn't defined otherwise.After
I now created a
svgo.config.js
file with the following content:website/svgo.config.js
This is how the dogfooding page looks with the config applied. We load the config from the generated files, which is written to while building:
Deploy preview: https://deploy-preview-10211--docusaurus-2.netlify.app/tests/docs/tests/svgs/
Related issues/PRs
Edit: I also just noticed https://github.com/facebook/docusaurus/issues/9192. No promises, but I'll give it a peek and see if this is something I can handle in the near future.