Open bohyunjung opened 1 month ago
Thanks
Yes we'll remove that plugin but it's technically a breaking change so it will be done for v4.
The plugin is already deprecated in our docs: https://docusaurus.io/docs/next/api/plugins/@docusaurus/plugin-google-analytics
@slorber Thank you for the triage.
It appears that the codebase is not yet accepting PRs for v4. Therefore, I'll leave the plugin itself as-is for now.
In the meantime, I'd like to propose making a PR with the following small changes:
What are your thoughts on this approach?
Thanks but I think it's fine in the current state, this warning is big enough
And broken links such as this one do not seem like a big deal either considering it prints "Service Unavailable": https://developers.google.com/analytics/devguides/collection/analyticsjs/
It's not super useful to improve a page that we plan to remove soon
Thanks for the quick feedback. I agree that these changes aren't necessary for the deprecated plugin at this time.
I'd like to note that the active plugin-google-gtag also has a broken link in its documentation:
If it's reasonable to fix this now, I'm happy to do so. Otherwise, I can keep this in mind for the v4 update.
Thanks, we'd want to fix this one indeed! (for all our docs versions). PR welcome.
It's weird that Google breaks links. They even discontinued their own link shortener recently. 😅
Have you read the Contributing Guidelines on issues?
Motivation
Task Details
Testing
Self-service