`@docusaurus/eslint-plugin` is not compatible with ESLint 9

facebook / docusaurus

Easy to maintain open source documentation websites.

https://docusaurus.io

MIT License

56.9k stars 8.56k forks source link

`@docusaurus/eslint-plugin` is not compatible with ESLint 9 #10490

Open Zamiell opened 2 months ago

Zamiell commented 2 months ago

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Description

See this dependency: https://github.com/facebook/docusaurus/blob/main/packages/eslint-plugin/package.json#L24

This needs to be upgraded to max, or else satisfying the peer deps is impossible on ESLint 9.

[ ] I'd be willing to fix this bug myself.

slorber commented 2 months ago

Thanks

I didn't have time to study the problem, but is the change retro-compatible and can be done in a minor?

@Josh-Cena you probably have an idea?

Josh-Cena commented 2 months ago

I haven't updated a plugin to ESLint v9 so I don't know if that would suffice, but so I hope. Does flat config require a new recommended config format?

Zamiell commented 2 months ago

Not sure.

Josh-Cena commented 2 months ago

For now, let's include v9 in the peer dep range, and then people can try it out. Worst case they would need to apply workarounds like they already do with other plugins like plugin-react-hooks. Once I become more informed about how shared flat configs work, we can make it a new entry point like many other plugins are doing, and none of these changes would be semver breaking.