facebook / docusaurus

Easy to maintain open source documentation websites.
https://docusaurus.io
MIT License
56.9k stars 8.56k forks source link

Code text not vertically aligned with regular text. #10652

Open ilg-ul opened 2 weeks ago

ilg-ul commented 2 weeks ago

Have you read the Contributing Guidelines on issues?

Prerequisites

Description

I noticed a small aestetic issue with code text, it is rendered slightly below the regular text baseline:

Screenshot 2024-11-07 at 20 01 20

My knowledge of CSS is poor, but I think that the reason is the code having vertical-align: middle.

Apparently setting it to baseline looks better:

Screenshot 2024-11-07 at 20 01 58

Reproducible demo

No response

Steps to reproduce

Define a H1 header with a short code in the middle

Expected behavior

All letters be aligned to the baseline.

Actual behavior

The code is below the baseline.

Your environment

Self-service

ilg-ul commented 2 weeks ago

I don't know if the code is aligned to middle on purpose or by mistake.

I added a small patch to my local css, and apparently the issue was fixed everywhere:

code {
  vertical-align: baseline;
}
ishsarin commented 2 weeks ago

Hi, can I work on this?