Closed slorber closed 2 weeks ago
Name | Link |
---|---|
Latest commit | b9687d625e3dab9b63f2bce43d0705843f5ba9b9 |
Latest deploy log | https://app.netlify.com/sites/docusaurus-2/deploys/672e47185b92b500089101e6 |
Deploy Preview | https://deploy-preview-10658--docusaurus-2.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Size Change: +225 B (0%)
Total Size: 11.2 MB
URL | Performance | Accessibility | Best Practices | SEO | Report |
---|---|---|---|---|---|
/ | đ 89 | đĸ 98 | đĸ 96 | đĸ 100 | Report |
/docs/installation | đ 55 | đĸ 97 | đĸ 100 | đĸ 100 | Report |
/docs/category/getting-started | đ 74 | đĸ 100 | đĸ 100 | đ 86 | Report |
/blog | đ 64 | đĸ 96 | đĸ 100 | đ 86 | Report |
/blog/preparing-your-site-for-docusaurus-v3 | đ´ 49 | đĸ 92 | đĸ 100 | đĸ 100 | Report |
/blog/tags/release | đ 64 | đĸ 96 | đĸ 100 | đ 86 | Report |
/blog/tags | đ 74 | đĸ 100 | đĸ 100 | đ 86 | Report |
Size Change: +215 B (0%)
Total Size: 11.7 MB
Thanks for the proposal @evenstensberg
This one is already merged but I can ping you on other Webpack-related things?
I'm also on the Rspack discord and getting some support here, since Webpack/Rspack have somehow the same API/behavior, but another pair of eyes might be useful.
Motivation
We are using Webpack copy-webpack-plugin to expose static assets from the
website/static
dir.These files are supposed to be exposed as-is, not being modified.
Unfortunately, we had a regression in Docusaurus v3.4 and the css/js minimizes started to be applied to these files as well. This is because I moved the copy plugin from webpack server config (minimizers disabled) to the client config (minimizers enabled): https://github.com/facebook/docusaurus/commit/17f3e02a4244b1893b7624ec3c948bfa926feacd
(there are good reasons to do so, in particular now that the server is built into a
__server
subfolder)Test Plan
CI + added a dogfood test to prevent regressions (site failed to build before I apply the fix)
Test links
https://deploy-preview-10658--docusaurus-2.netlify.app/
Related issues/PRs
fix https://github.com/facebook/docusaurus/issues/10460
fix https://github.com/facebook/docusaurus/issues/10334