facebook / docusaurus

Easy to maintain open source documentation websites.
https://docusaurus.io
MIT License
56.7k stars 8.53k forks source link

dark mode: Callouts/admonitions #4321

Closed armano2 closed 3 years ago

armano2 commented 3 years ago

🐛 Bug Report

Dark mode is missing default styles for admonitions/alerts

Have you read the Contributing Guidelines on issues?

yes

To Reproduce

https://v2.docusaurus.io/docs/markdown-features#calloutsadmonitions in dark mode

image

Expected behavior

there should be predefined styles for callouts in dark mode

as workaround i added to my styles, but those styles should be predefined

html[data-theme='dark'] .alert--secondary {
  --ra-admonition-icon-color: var(--ifm-color-emphasis-900);
  --ifm-alert-background-color: var(--ifm-color-emphasis-100);
  --ifm-alert-border-color: var(--ifm-color-emphasis-200);
  --ifm-alert-color: var(--ifm-color-emphasis-900);
}

image

Actual Behavior

there is no syles for dark mode callouts

Your Environment

slorber commented 3 years ago

Hi,

We plan to have a new admonition design, there's this Infima issue to track it: https://github.com/facebookincubator/infima/issues/55