facebook / docusaurus

Easy to maintain open source documentation websites.
https://docusaurus.io
MIT License
56.93k stars 8.57k forks source link

List of forked and to-be-forked dependencies #6246

Open Josh-Cena opened 2 years ago

Josh-Cena commented 2 years ago

Docusaurus forked the following dependencies to add our own functionality:

☝️All forks that I'm aware of. Below are some packages we should fork & maintain ourselves:

slorber commented 2 years ago

Thanks for listing those! Hope we'll get the org soon

Josh-Cena commented 2 years ago

@slorber Any idea why react-loadable-ssr-addon was forked? Did you just publish without committing to your fork? The version on NPM is still what was originally forked though

slorber commented 2 years ago

I think it's using another branch (the one I used to open the pending PR, not main: https://github.com/themgoncalves/react-loadable-ssr-addon/pull/28#issuecomment-810369906)

https://github.com/slorber/react-loadable-ssr-addon/tree/slorber/fix-webpack5-warning

slorber commented 2 years ago

For the upcoming GitHub organization, adding this starter that is used in a few places. We may have more starters/example repos later.

https://github.com/slorber/docusaurus-starter

zpao commented 2 years ago

How current is this list? Can we switch back to upstream for any of these?

jpdriver commented 2 years ago

hey all 👋🏻 i don't mean to pollute this thread, but just to mention that as the lead maintainer for both react-live and prism-react-renderer I'd love to collaborate on whatever changes would need to be made to keep docusaurus on the latest upstream versions of those libs 🙇🏻‍♂️

Josh-Cena commented 2 years ago

How current is this list? Can we switch back to upstream for any of these?

@zpao react-live is being migrated away from in #6589, so it can probably not be forked. prism-react-renderer can probably stay for now. Everything else is still relevant. I've updated the list. We don't have any newly forked dependencies, since we are still waiting for the @docusaurus org.


@jpdriver Oh, great news! I'm not sure what the status of prism-react-renderer is, I honestly thought it's quasi-dead from the update frequency... I'm going to dump a few issues and possibly PRs in the next few days.

react-live seems to have a React version mismatch, iirc, which is why we are still pinning it to 2.2.3. Has it be fixed over time, or is it only fixable by migrating to v3? I think react-runner seems promising enough—it seems the major advantage of this package, apart from Sucrase (which you are already migrating to in v3), is SSR. Does react-live have plans to support SSR?

jpdriver commented 2 years ago

@Josh-Cena happy to keep chatting here or move to some other venue if there's a more appropriate place!

yep prism-react-renderer hadn't been active for a while, but i'm hoping to change that. i'd be happy to review any issues and PRs you open.

For react-live, the version mismatch issue was resolved with v3. The project did previously support SSR, but unfortunately due to our current usage of Hooks we’ve lost that along the way.

if I’m missing something obvious and there is a way to re-introduce SSR support, i’d love to do that 😅


updated: react-live's SSR regression will be fixed in https://github.com/FormidableLabs/react-live/issues/321