A line break inside a markdown link will break url rendering

chromy96 commented 1 year ago

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[ ] I have tried creating a repro with https://new.docusaurus.io.
[ ] I have read the console error message carefully (if applicable).

Description

Two URLs containing a file path to the same document will be rendered differently depending on if the link text contains a line break or not.

Properly rendered url (points to website/docs/example)

[A link example](example.md)

Badly rendered url (points to website/example.md)

[A link
example](example.md)

Docusaurus version: 3.0.0

Reproducible demo

No response

Steps to reproduce

Create a link with a line break in it
Check how the URL is rendered

Expected behavior

Expected a URL to be rendered the same way as without the line break.

Actual behavior

A link points to website/example.md instead of website/docs/example

Your environment

Public source code:
Public site URL:
Docusaurus version used: 3.0.0
Environment name and version (e.g. Chrome 89, Node.js 18.2): Chrome 119, Node.js 18.2
Operating system and version (e.g. Ubuntu 20.04.2 LTS): Ubuntu 20.04

Self-service

[ ] I'd be willing to fix this bug myself.

Josh-Cena commented 1 year ago

This is currently working as intended because we only process links line-by-line. We can investigate making it multiline but I wonder if it would be as trivial as the other Markdown link bugs. We'll soon use an actual Markdown parser for this.

slorber commented 1 year ago

Closing as duplicate of https://github.com/facebook/docusaurus/issues/9048

This bug is only there because we don't use MDX/Remark/micromark to resolve links using filename extensions.

facebook / docusaurus