slorber
commented
8 months ago A 30k blog post? 🤯 why do you have so many?
Yes, it seems like we should not use JSON.stringify but instead use a serialization lib supporting streaming.
For example https://github.com/dominictarr/JSONStream#jsonstreamstringifyopen-sep-close
Note to myself: I'll probably take this opportunity to encapsulate this streaming, and expose simpler, more testable interfaces to create route data bundles because I'm not a fan of our historic plugin actions API for that:
// Create a blog archive route
const archiveProp = await createData(
`${docuHash(archiveUrl)}.json`,
JSON.stringify({blogPosts: listedBlogPosts}, null, 2),
);
addRoute({
path: archiveUrl,
component: blogArchiveComponent,
exact: true,
modules: {
archive: aliasedSource(archiveProp),
},
});That would be more convenient to have everything handled for you, and just write:
addRoute({
path: archiveUrl,
component: blogArchiveComponent,
exact: true,
props: {
archive: {blogPosts: listedBlogPosts},
},
});Note we'd still need to keep a way to create data bundles independent from routes (+ streaming support), because those data bundles can be shared between routes, reducing the amount of data to load when navigating from one route to another. (although this data could probably be added as a routeContext)
ardavank
sserrata
Have you read the Contributing Guidelines on issues?
Prerequisites
npm run clearoryarn clearcommand.rm -rf node_modules yarn.lock package-lock.jsonand re-installing packages.Description
docusaurus build returns
RangeError: Invalid string lengthwhen building the website with a very large number of blogs (~30K)Error:
Looking at the code, it looks like
JSON.stringify({ blogPosts: listedBlogPosts }is the problematic partReproducible demo
No response
Steps to reproduce
Expected behavior
Actual behavior
it throws
RangeError: Invalid string lengthYour environment
Self-service