facebook / dotslash

Simplified executable deployment
https://dotslash-cli.com
Apache License 2.0
535 stars 14 forks source link

feat(release): release with cargo-dist #19

Open ashleygwilliams opened 3 months ago

ashleygwilliams commented 3 months ago

hey folks! love what you're doing with this project. long ago i mentioned to @dtolnay that it might be valuable to consider distributing dotslash with cargo-dist. tl;dr cargo-dist generated github workflows from config in your Cargo.toml.

i've done an example in a fork- you can view the generated release here: https://github.com/ashleygwilliams/dotslash/releases/tag/v0.2.1

this enables some installers (curl, powershell, homebrew, npm) you don't yet have and can auto publish to registries/taps if you'd like. i think i may have shuffled some of your target support- but we can add whatever targets you might need :)

facebook-github-bot commented 3 months ago

Hi @ashleygwilliams!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!