search

facebook / dotslash

Simplified executable deployment
https://dotslash-cli.com
Apache License 2.0
535 stars 14 forks source link

Introduce GitLab Releases Provider #3

Open alilleybrinker opened 4 months ago

alilleybrinker commented 4 months ago

NOTE: This is still a draft. I haven't yet tested it out against a GitLab Release to ensure it does the right thing. This is just the initial code modeled after the GitHub Releases provider implementation.

This commit implements a GitLab Releases provider, modeled after the GitHub Releases provider. It uses the glab command line interface (CLI) to handle downloads, and delegates to that CLI for error handling.

I did experiment briefly with using the Rust glob crate to eagerly identify errors in glob patterns passed for matching artifacts, but that crate didn't exactly match the Go path/filepath.Match logic and I didn't want to introduce any weird incompatibilities between the two layers.

Related: #2

facebook-github-bot commented 4 months ago

Hi @alilleybrinker!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!