search

facebook / dotslash

Simplified executable deployment
https://dotslash-cli.com
Apache License 2.0
535 stars 14 forks source link

Support zip in Artifact Format #8

Closed hn8 closed 3 months ago

hn8 commented 4 months ago

Will you be open to PR for supporting zip format? For example https://github.com/dprint/dprint/releases. Thanks!

bolinfest commented 4 months ago

I feel like we tried supporting zip internally at Meta and ran into some issues. Something like the zip Rust crate didn't support all zip files we tested it with?

Hopefully @zertosh remembers...

zertosh commented 4 months ago

We tried zip-rs when they were at v0.5.0 (mid-2019). At the time it had terrible perf and it didn't handle symlinks. I don't know if the issues have been resolved. It's worth revisiting though.

abhinav commented 4 months ago

Took an initial stab at this using zip-rs. https://github.com/facebook/dotslash/pull/13 It worked fine with the dprint archive; I didn't test it with anything else.

abhinav commented 4 months ago

@hn8 Please re-open the issue. The change hasn't been merged into the official repository yet.