search

facebook / duckling

Language, engine, and tooling for expressing, testing, and evaluating composable language rules on input strings.
Other
4.08k stars 725 forks source link

ghc88x compat #550

Closed chessai closed 3 years ago

facebook-github-bot commented 3 years ago

@chessai has updated the pull request. You must reimport the pull request before landing.

chessai commented 3 years ago

The issues with KA tests cannot be overcome without significant refactoring of Document/isRangeValid. See #514 #420 #442

facebook-github-bot commented 3 years ago

@chessai merged this pull request in facebook/duckling@cdeefe1d4d6a72d2e6a6334fbb3a77d0772a9821.