search

facebook / duckling

Language, engine, and tooling for expressing, testing, and evaluating composable language rules on input strings.
Other
4.08k stars 725 forks source link

Language oopsie in Duckling.Time.NL.Rules #601

Open Vlix opened 3 years ago

Vlix commented 3 years ago

ruleADuration in Duckling.Time.NL.Rules has a German pattern, instead of a Dutch one.

EDIT: Also these

chessai commented 3 years ago

Wow! This must've not been reviewed properly internally. Bad copy/paste error I am guessing. Nice catch.

Would you happen to be interested in preparing a PR?

Vlix commented 3 years ago

Personally don't have much time to do this at the moment.

chessai commented 3 years ago

Personally don't have much time to do this at the moment.

No problem, thanks for reporting the issue!