search

facebook / duckling

Language, engine, and tooling for expressing, testing, and evaluating composable language rules on input strings.
Other
4.05k stars 723 forks source link

Support for LATAM Currencies #627

Open clobotorre opened 3 years ago

clobotorre commented 3 years ago

Could you please add suppor in duckling for the next currencies used in LATAM countries?

Peso / Pesos: Colombia, Chile, Argentina, Uruguay, República Dominicana, México Bolívar / Bolívares: Venezuela Sol / Soles: Perú Boliviano / Bolivianos: Bolivia Real / Reales: Brasil Guaraní / Guaraníes: Paraguay Colón / Colones: Costa Rica Lempira / Lempiras: Honduras Córdoba / Córdobas: Nicaragua

chessai commented 3 years ago

Would you be interested in PRing some?

clobotorre commented 3 years ago

Sorry, I didn't understand "PRing". Could you explain it?

chessai commented 3 years ago

I mean, would you like to PR some of these additions?

clobotorre commented 3 years ago

Sorry again. I'm not a native English. I don't undestand the meaning of "PR"

chessai commented 3 years ago

Oh, sorry. PR means pull request, as in, a GitHub pull request.

clobotorre commented 3 years ago

I'm sorry but I don't know Haskell language enough to be able to make the changes, and I think it could waste your time

chessai commented 3 years ago

I'm sorry but I don't know Haskell language enough to be able to make the changes, and I think it could waste your time

No problem, I'll work on adding these.