Ca time improvements - Githubissues

facebook / duckling

Language, engine, and tooling for expressing, testing, and evaluating composable language rules on input strings.

Other

4.05k stars 720 forks source link

Ca time improvements #644

Closed fil090302 closed 2 years ago

fil090302 commented 3 years ago

Some time improvements in Catalan:

allow 'febr' as abbreviation for February and 'ag' as abbreviation for August
better understanding of parts of day - morning / afternoon / evening / night

chessai commented 3 years ago

Left some comments.

fil090302 commented 2 years ago

Hi @chessai left some inline comments on the Rules.hs file. The Corpus.hs changes follows from those rule changes.

Generally, these changes were to make the time range of different parts of day more consistent with similar languages. If you think some are not useful, let me know and I'll remove.

fil090302 commented 2 years ago

Hi @chessai , any idea when/if this can be merged? Let me know if you need me to change some assumptions. thanks