search

facebook / duckling

Language, engine, and tooling for expressing, testing, and evaluating composable language rules on input strings.
Other
4.05k stars 720 forks source link

Add Japanese time dimension #646

Closed udiu closed 2 years ago

udiu commented 3 years ago

Add the most common rules for Japanese time dimension.

chessai commented 3 years ago

This looks good! I'll have an internal Japanese speaker review it. Can you remove commented-out corpora tests?

chessai commented 3 years ago

CI failure seems unrelated, like a transient windows runner bug

EDIT: I restarted CI and it looks good now.

udiu commented 3 years ago

This looks good! I'll have an internal Japanese speaker review it. Can you remove commented-out corpora tests?

That will be super useful. I removed the commented corpus. Thanks!

facebook-github-bot commented 3 years ago

@chessai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

udiu commented 2 years ago

Hi @chessai, do you have any news about the review of this PR from the internal Japanese speaker?

chessai commented 2 years ago

Hi @chessai, do you have any news about the review of this PR from the internal Japanese speaker?

Hi @udiu, sorry for the delay. The code received an internal review from Japanese speakers and I need to forward them along here (Normally, I would handle them myself internally, but my confidence that I can do so with Japanese is very low, so I'm going to forward them out externally)

facebook-github-bot commented 2 years ago

@chessai merged this pull request in facebook/duckling@dd70d80dc1c9b47a8b68ce36ba12c0da4e376d3e.