Closed udiu closed 2 years ago
This looks good! I'll have an internal Japanese speaker review it. Can you remove commented-out corpora tests?
CI failure seems unrelated, like a transient windows runner bug
EDIT: I restarted CI and it looks good now.
This looks good! I'll have an internal Japanese speaker review it. Can you remove commented-out corpora tests?
That will be super useful. I removed the commented corpus. Thanks!
@chessai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Hi @chessai, do you have any news about the review of this PR from the internal Japanese speaker?
Hi @chessai, do you have any news about the review of this PR from the internal Japanese speaker?
Hi @udiu, sorry for the delay. The code received an internal review from Japanese speakers and I need to forward them along here (Normally, I would handle them myself internally, but my confidence that I can do so with Japanese is very low, so I'm going to forward them out externally)
@chessai merged this pull request in facebook/duckling@dd70d80dc1c9b47a8b68ce36ba12c0da4e376d3e.
Add the most common rules for Japanese time dimension.