facebook-github-bot
commented
2 years ago Hi @DanBmh!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!
kkannar-infinitusai
jackpotandy
chessai
This PR add automatic testing while building the docker image, as well as an arm64 version.
I'm already using them as part of the offline voice assistant Jaco, but I thought it would be a good idea to merge this back into the official repo. Currently you can find the prebuilt images in Jaco's GitLab container registry: Link. (As mentioned in https://github.com/facebook/duckling/issues/638, you can also find an armhf image there, but since Jaco doesn't use it in its current version it isn't maintained anymore)
It would be great if you could provide official images through docker hub or somewhere else. I've seen this already was requested in https://github.com/facebook/duckling/issues/544, where missing tests where a reason for rejection, so I added some to the files.