search

facebook / duckling

Language, engine, and tooling for expressing, testing, and evaluating composable language rules on input strings.
Other
4.05k stars 719 forks source link

Support Persian(fa) Languages #712

Closed AmirMohamadBabaee closed 1 year ago

AmirMohamadBabaee commented 1 year ago

First, thanks for your fantastic repo. Could you let me know if you plan to support the Persian language?

chessai commented 1 year ago

Farsi numerals are supported: https://github.com/facebook/duckling/blob/main/Duckling/Numeral/FA/Rules.hs

But it looks like most dimensions do not have Farsi support.

Typically, new language support in Duckling is added by third-party developers and not the duckling team, since the Duckling team is small and has fluent understanding of a minimal set of languages (English, French, Mandarin, Cantonese).

If you would like to see more Farsi support, I encourage you to take a stab at it!

AmirMohamadBabaee commented 1 year ago

Thanks for your quick reply. I am very eager to contribute to this wonderful project, but I have no experience in Haskell. Is there a template for defining Persian rules in other dimensions?

stroxler commented 1 year ago

For the code itself, your best bet would probably be to look at some of the existing implementations to understand how rules are laid out.

I'd recommend starting with some dimension other than Time, those rules tend to be very complex but others are usually much simpler.

AmirMohamadBabaee commented 1 year ago

Thanks, @stroxler