facebook / facebook-android-sdk

Used to integrate Android apps with Facebook Platform.
https://developers.facebook.com/docs/android
Other
6.17k stars 3.66k forks source link

Fix recreating FacebookActivity with LoginFragment #1208

Closed admund closed 7 months ago

admund commented 1 year ago

Thanks for proposing a pull request!

To help us review the request, please complete the following:

Pull Request Details

Fix for this issue https://github.com/facebook/facebook-android-sdk/issues/1151 When we try to recreate FacebookActivity with LoginFragment, we need to reinitialize SDK first, then we can start recreating fragments.

Test Plan

Test Plan: Add your test plan here

facebook-github-bot commented 1 year ago

Hi @admund!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!