facebook / facebook-android-sdk

Used to integrate Android apps with Facebook Platform.
https://developers.facebook.com/docs/android
Other
6.07k stars 3.64k forks source link

ConcurrentModificationException on FetchedAppGateKeepersManager.getGateKeepersForApplication #1210

Open eloisance opened 8 months ago

eloisance commented 8 months ago

Checklist before submitting a bug report

Java version

1.8

Android version

17

Android SDK version

33

Installation platform & version

Gradle

Package

Core & AppEvents

Goals

After upgrading the Facebook SDK from 16.1.3 to 16.2.0 in our latest version 3.122.0 we started to see this crash for some of our users in Firebase. The crash seems to happen at the app startup because we don't have any logs in Firebase Crashlytics.

Screenshot 2023-09-07 at 10 44 46

Expected results

No crash should happen

Actual results

Stacktrace :

Fatal Exception: java.util.ConcurrentModificationException:
       at java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:757)
       at java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:780)
       at com.facebook.internal.FetchedAppGateKeepersManager.getGateKeepersForApplication(FetchedAppGateKeepersManager.kt:165)
       at com.facebook.internal.FetchedAppGateKeepersManager.getGateKeeperForKey(FetchedAppGateKeepersManager.kt:177)
       at com.facebook.internal.FeatureManager.getGKStatus(FeatureManager.kt:107)
       at com.facebook.internal.FeatureManager.isEnabled(FeatureManager.kt:54)
       at com.facebook.internal.FeatureManager.isEnabled(FeatureManager.kt:54)
       at com.facebook.internal.Utility.setAppEventAttributionParameters(Utility.kt:578)
       at com.facebook.applinks.AppLinkData.fetchDeferredAppLinkFromServer(AppLinkData.java:143)
       at com.facebook.applinks.AppLinkData.access$000(AppLinkData.java:36)
       at com.facebook.applinks.AppLinkData$1.run(AppLinkData.java:131)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
       at java.lang.Thread.run(Thread.java:919)

Steps to reproduce

No able to reproduce

Code samples & details

No response

efguydan commented 7 months ago

I have this same bug. Is there anything that can be done about it?

efguydan commented 6 months ago

Hello. Is there anything that can be done about this? THe issue still persists. Thank you

efguydan commented 5 months ago

Hey 👋🏽 It would be great to get some activity on this about what we can try. This issue is really affecting our application and there was a spike earlier this week .

image

Would really appreciate a response, Thanks