Crash in FBSDKRestrictiveDataFilterManager.m line 80

clayjonezie commented 4 years ago

Checklist

[X] I've updated to the latest released version of the SDK (we are experiencing this on an older version from previous builds, FBSDK 6.5.0. I do not know if FBSDK 6.5.2 resolves the issue.)
[X] I've searched for existing GitHub issues
[X] I've looked for existing answers on Stack Overflow, the Facebook Developer Community Forum and the Facebook Developers Group
[X] I've read the Code of Conduct
[x] This issue is not security related and can safely be disclosed publicly on GitHub

Environment

Describe your dev environment here, giving as many details as possible. If you have them, make sure to include:

Xcode Version: 11.4.1
FBSDK 6.5.0 (at time of build)

Goals

What do you want to achieve?

We are using FBSDK in our app as an authentication option

Expected Results

What do you expect to happen?

I would like FBSDK to not crash

Actual Results

What actually happened? Can you provide a stack trace?

FBSDK is crashing at a large volume.

Steps to Reproduce

What are the steps necessary to reproduce this issue?

I'm not sure yet, this is happening intermittently (but at a high volume) in the field.

Code Samples & Details

Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x1a5c2896c __exceptionPreprocess
1  libobjc.A.dylib                0x1a5941028 objc_exception_throw
2  CoreFoundation                 0x1a5b26dcc -[NSOrderedSet initWithSet:copyItems:]
3  CoreFoundation                 0x1a5c2d048 ___forwarding___
4  CoreFoundation                 0x1a5c2f3a0 _CF_forwarding_prep_0
5  FBSDKCoreKit                   0x1039830cc +[FBSDKRestrictiveDataFilterManager updateFilters:] + 80 (FBSDKRestrictiveDataFilterManager.m:80)
6  FBSDKCoreKit                   0x103985f34 +[FBSDKServerConfigurationManager processLoadRequestResponse:error:appID:] + 240 (FBSDKServerConfigurationManager.m:240)
7  FBSDKCoreKit                   0x103985750 __78+[FBSDKServerConfigurationManager loadServerConfigurationWithCompletionBlock:]_block_invoke + 161 (FBSDKServerConfigurationManager.m:161)
8  FBSDKCoreKit                   0x103969c5c -[FBSDKGraphRequestMetadata invokeCompletionHandlerForConnection:withResults:error:] + 41 (FBSDKGraphRequestMetadata.m:41)
9  FBSDKCoreKit                   0x103967534 __82-[FBSDKGraphRequestConnection processResultBody:error:metadata:canNotifyDelegate:]_block_invoke + 806 (FBSDKGraphRequestConnection.m:806)
10 FBSDKCoreKit                   0x103967428 -[FBSDKGraphRequestConnection processResultBody:error:metadata:canNotifyDelegate:] + 839 (FBSDKGraphRequestConnection.m:839)
11 FBSDKCoreKit                   0x103967038 __64-[FBSDKGraphRequestConnection completeWithResults:networkError:]_block_invoke + 788 (FBSDKGraphRequestConnection.m:788)
12 CoreFoundation                 0x1a5bfa66c __NSARRAY_IS_CALLING_OUT_TO_A_BLOCK__
13 CoreFoundation                 0x1a5af822c -[__NSArrayM enumerateObjectsWithOptions:usingBlock:]
14 FBSDKCoreKit                   0x103966dfc -[FBSDKGraphRequestConnection completeWithResults:networkError:] + 767 (FBSDKGraphRequestConnection.m:767)
15 FBSDKCoreKit                   0x1039662b0 -[FBSDKGraphRequestConnection completeFBSDKURLSessionWithResponse:data:networkError:] + 634 (FBSDKGraphRequestConnection.m:634)
16 FBSDKCoreKit                   0x10396443c __36-[FBSDKGraphRequestConnection start]_block_invoke_3 + 242 (FBSDKGraphRequestConnection.m:242)
17 libdispatch.dylib              0x1a58ccb7c _dispatch_call_block_and_release
18 libdispatch.dylib              0x1a58cdfd8 _dispatch_client_callout
19 libdispatch.dylib              0x1a58d9cc8 _dispatch_main_queue_callback_4CF
20 CoreFoundation                 0x1a5ba3cc8 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
21 CoreFoundation                 0x1a5b9ea24 __CFRunLoopRun
22 CoreFoundation                 0x1a5b9df40 CFRunLoopRunSpecific
23 GraphicsServices               0x1afe2e534 GSEventRunModal
24 UIKitCore                      0x1a9d29580 UIApplicationMain
25 AllTrails                      0x10233876c main + 21 (UIDevice+Storage.swift:21)
26 libdyld.dylib                  0x1a5a1ce18 start

mmdock commented 4 years ago

similar crash log: SDK version 5.6.0

Fatal Exception: NSInvalidArgumentException 0 CoreFoundation 0x1a5d4c96c exceptionPreprocess 1 libobjc.A.dylib 0x1a5a65028 objc_exception_throw 2 CoreFoundation 0x1a5c4adcc -[NSOrderedSet initWithSet:copyItems:] 3 CoreFoundation 0x1a5d51048 __forwarding 4 CoreFoundation 0x1a5d533a0 _CF_forwarding_prep_0 5 FBSDKCoreKit 0x10174a2e0 +[FBSDKRestrictiveDataFilterManager updateFilters:] + 68 (FBSDKRestrictiveDataFilterManager.m:68) 6 FBSDKCoreKit 0x10174cbac +[FBSDKServerConfigurationManager processLoadRequestResponse:error:appID:] + 258 (FBSDKServerConfigurationManager.m:258) 7 FBSDKCoreKit 0x10174c418 78+[FBSDKServerConfigurationManager loadServerConfigurationWithCompletionBlock:]_block_invoke + 162 (FBSDKServerConfigurationManager.m:162) 8 FBSDKCoreKit 0x10173c740 -[FBSDKGraphRequestMetadata invokeCompletionHandlerForConnection:withResults:error:] + 41 (FBSDKGraphRequestMetadata.m:41) 9 FBSDKCoreKit 0x10173a030 82-[FBSDKGraphRequestConnection processResultBody:error:metadata:canNotifyDelegate:]_block_invoke + 801 (FBSDKGraphRequestConnection.m:801) 10 FBSDKCoreKit 0x101739f24 -[FBSDKGraphRequestConnection processResultBody:error:metadata:canNotifyDelegate:] + 834 (FBSDKGraphRequestConnection.m:834) 11 FBSDKCoreKit 0x101739b34 64-[FBSDKGraphRequestConnection completeWithResults:networkError:]_block_invoke + 783 (FBSDKGraphRequestConnection.m:783) 12 CoreFoundation 0x1a5d1e66c NSARRAY_IS_CALLING_OUT_TO_A_BLOCK 13 CoreFoundation 0x1a5c1c22c -[NSArrayM enumerateObjectsWithOptions:usingBlock:] 14 FBSDKCoreKit 0x1017398f8 -[FBSDKGraphRequestConnection completeWithResults:networkError:] + 762 (FBSDKGraphRequestConnection.m:762) 15 FBSDKCoreKit 0x101738db4 -[FBSDKGraphRequestConnection completeFBSDKURLSessionWithResponse:data:networkError:] + 629 (FBSDKGraphRequestConnection.m:629) 16 FBSDKCoreKit 0x101736f90 36-[FBSDKGraphRequestConnection start]_block_invoke_3 + 242 (FBSDKGraphRequestConnection.m:242) 17 libdispatch.dylib 0x1a59f0b7c _dispatch_call_block_and_release 18 libdispatch.dylib 0x1a59f1fd8 _dispatch_client_callout 19 libdispatch.dylib 0x1a59fdcc8 _dispatch_main_queue_callback_4CF 20 CoreFoundation 0x1a5cc7cc8 CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE 21 CoreFoundation 0x1a5cc2a24 CFRunLoopRun 22 CoreFoundation 0x1a5cc1f40 CFRunLoopRunSpecific 23 GraphicsServices 0x1aff52534 GSEventRunModal 24 UIKitCore 0x1a9e4d580 UIApplicationMain 25 Her 0x10008b8e8 main + 11 (main.swift:11) 26 libdyld.dylib 0x1a5b40e18 start

ericrwolfe commented 4 years ago

I'm also seeing a large spike in crashes in the past two hours with the same stack trace. FBSDKCoreKit 6.0.0, Xcode 11.3.1.

hberberoglu commented 4 years ago

We are also experiencing this. It started suddenly about ~1 hour ago. iOSv5.15.1

Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x181c16d8c __exceptionPreprocess
1  libobjc.A.dylib                0x180dd05ec objc_exception_throw
2  CoreFoundation                 0x181c24098 __methodDescriptionForSelector
3  CoreFoundation                 0x181c1c5c8 ___forwarding___
4  CoreFoundation                 0x181b0241c _CF_forwarding_prep_0
5  MyAppName            0x100f2ab98 +[FBSDKRestrictiveDataFilterManager updateFilters:] + 68 (FBSDKRestrictiveDataFilterManager.m:68)
6  MyAppName            0x100f2d790 +[FBSDKServerConfigurationManager processLoadRequestResponse:error:appID:] + 258 (FBSDKServerConfigurationManager.m:258)
7  MyAppName            0x100f1e120 __69+[FBSDKGraphRequestPiggybackManager addServerConfigurationPiggyback:]_block_invoke + 151 (FBSDKGraphRequestPiggybackManager.m:151)
8  MyAppName            0x100f1ca10 -[FBSDKGraphRequestMetadata invokeCompletionHandlerForConnection:withResults:error:] + 41 (FBSDKGraphRequestMetadata.m:41)
9  MyAppName            0x100f1a170 __82-[FBSDKGraphRequestConnection processResultBody:error:metadata:canNotifyDelegate:]_block_invoke + 801 (FBSDKGraphRequestConnection.m:801)
10 MyAppName            0x100f1a054 -[FBSDKGraphRequestConnection processResultBody:error:metadata:canNotifyDelegate:] + 834 (FBSDKGraphRequestConnection.m:834)
11 MyAppName            0x100f19c64 __64-[FBSDKGraphRequestConnection completeWithResults:networkError:]_block_invoke + 783 (FBSDKGraphRequestConnection.m:783)
12 CoreFoundation                 0x181af0a20 -[__NSArrayM enumerateObjectsWithOptions:usingBlock:]
13 MyAppName            0x100f19a08 -[FBSDKGraphRequestConnection completeWithResults:networkError:] + 762 (FBSDKGraphRequestConnection.m:762)
14 MyAppName            0x100f18e98 -[FBSDKGraphRequestConnection completeFBSDKURLSessionWithResponse:data:networkError:] + 629 (FBSDKGraphRequestConnection.m:629)
15 MyAppName            0x100f16f7c __36-[FBSDKGraphRequestConnection start]_block_invoke_3 + 242 (FBSDKGraphRequestConnection.m:242)
16 libdispatch.dylib              0x181508aa0 _dispatch_call_block_and_release
17 libdispatch.dylib              0x181508a60 _dispatch_client_callout
18 libdispatch.dylib              0x18151565c _dispatch_main_queue_callback_4CF$VARIANT$mp
19 CoreFoundation                 0x181bbf070 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
20 CoreFoundation                 0x181bbcbc8 __CFRunLoopRun
21 CoreFoundation                 0x181adcda8 CFRunLoopRunSpecific
22 GraphicsServices               0x183ac1020 GSEventRunModal
23 UIKit                          0x18baf9758 UIApplicationMain
24 MyAppName            0x100daf99c main + 16 (main.m:16)
25 libdyld.dylib                  0x18156dfc0 start

snowtema commented 4 years ago

The same problem. My app crashing on live users...

kevinmun commented 4 years ago

Also experiencing huge amount of crashes, still persisting, @tianqibt , any time to resolution or thread where we can check this out?

rromanchuk commented 4 years ago

this again

kevinmun commented 4 years ago

let's merge this into https://github.com/facebook/facebook-ios-sdk/issues/1373

Yelles commented 4 years ago

many apps (Spotify, Viber, etc) are crashing right now... Seems to be a Facebook SDK related issue

lucas-tl commented 4 years ago

We are also affected by this. Please move slower and break fewer things. Thank you.

johnkassebaum commented 4 years ago

What parameterizes 'few' for you?

pangia commented 4 years ago

crashing our entire userbase.

johnkassebaum commented 4 years ago

Ours too

willswire commented 4 years ago

Pinterest, GroupMe apps crashing on launch.

Also, huge iCloud outage right now - mail hasn't been delivered since 6 PM EST yesterday!! Not sure if it's related or not.

andyjohns commented 4 years ago

Yeah, same here. All users regardless if they use FB to login or not.

rromanchuk commented 4 years ago

this is the second time now this SDK has deadmanswitched because of a remote config. I can make my own branching mistakes i dont need additional. Not trying to pile on, but this is not the first time you guys have bricked apps due to release management. It feels a little more nefarious than your typical "server changed response and model now breaks".

juanchoabdon commented 4 years ago

Same error here!

johnkassebaum commented 4 years ago

Still crashing 30 minutes after your revert. Are you sure you reverted the right thing?

daniel-beard commented 4 years ago

@tianqibt "a few minutes" isn't really an acceptable response for a crash that's taken down our entire userbase. Still crashing for me.

What steps in the future will be taken to prevent this?

AndrewYab commented 4 years ago

Are you sure this has been reverted correctly? Our apps are still crashing...

DanielRaouf commented 4 years ago

Affected by this as well. That is very urgent.

ArielDemarco commented 4 years ago

The change needs a some time to be propagated to all server. Some apps already seen the crash stopped. We also turned off the feature. It will be effective within a few minutes.

How much time shall we consider "normal" to wait? Still seeing crashes in our app.

bruno1308 commented 4 years ago

Don't fire the intern! We all make mistakes!!

Edit: the world is already hard as is. Put yourself in the shoes of the team that is responsible for this. They must be stressed a.f. knowing that they are crashing the whole iOS ecosystem. So stop pressuring them and give them time to peacefully make their fixes. Life goes on.