facebook / facebook-ios-sdk

Used to integrate the Facebook Platform with your iOS & tvOS apps.
https://developers.facebook.com/docs/ios
Other
7.8k stars 3.56k forks source link

App suddenly crashing on startup in production due to FBSDKRestrictiveDataFilterManager.m #1427

Closed nicklocking closed 4 years ago

nicklocking commented 4 years ago

Checklist

Environment

Describe your dev environment here, giving as many details as possible. If you have them, make sure to include:

Production. Facebook SDK 5.0.2.

Goals

What do you want to achieve?

My company's app to not crash in production.

Expected Results

What do you expect to happen?

My app to work properly in production.

Actual Results

What actually happened? Can you provide a stack trace?

The app crashes on open, because of Facebook's SDK, starting at 10:53PM PST. Seems to be happening for 100% of users. 1400 crashes in the last 16 minutes.

FBSDKRestrictiveDataFilterManager.m - Line 108
+[FBSDKRestrictiveDataFilterManager updateFilters:restrictiveParams:] + 108

Steps to Reproduce

What are the steps necessary to reproduce this issue?

Open our app, Pray.com.

agam-mahajan-swiggy commented 4 years ago

Happening for my App also. 'FBSDKCoreKit' , '5.1.1' for all the users.

ethanhuang13 commented 4 years ago

Happening on my app. tvOS with FBSDKCoreKit v5.8.0. (However the iOS app with the same SDK version is not affected.)

furthergo commented 4 years ago

APP using FBSDKCoreKit v5.0.2 is crash, which using FBSDKCoreKit v5.4.1 is OK

sekitaka commented 4 years ago

APP using FBSDKCoreKit v5.0.2 is crash, which using FBSDKCoreKit v7.1.1 is OK

PrLion commented 4 years ago

Please fix this ASAP.

agam-mahajan-swiggy commented 4 years ago

Upgraded FBSDKCoreKit to 7.1.1. Working fine now For existing users, Had a kill switch to disable SDK

PrLion commented 4 years ago

Upgraded FBSDKCoreKit to 7.1.1. Working fine now For existing users, Had a kill switch to disable SDK

Did you solve it?

agam-mahajan-swiggy commented 4 years ago

I think the issue is with the older SDKs. I'm not exactly sure what is causing the issue. After updating to the latest SDK, it's not crashing

Before also a discussion happened on this crash. https://github.com/facebook/facebook-ios-sdk/issues/1374

PrLion commented 4 years ago

I think the issue is with the older SDKs. I'm not exactly sure what is causing the issue. After updating to the latest SDK, it's not crashing

Before also a discussion happened on this crash.

1374

Yep. But if app in store we can't solve it ourself. Only update.

puneet1106 commented 4 years ago

For FBSDKCoreKit v5.0.2 facing this issue. Please fix this ASAP.

agam-mahajan-swiggy commented 4 years ago

@PrLion yeah. For my app on App Store, it worked because of the kill switch which is controlled remotely. I disabled SDK when got crash alert.

Now Either we have to wait for the FB team to reply and fix this or you can meanwhile upgrade to latest SDK (try 7.1.1) and request for expedite release to the Apple team.

Also, add some kill switch for this SDK so that this kind of situation doesn't come again.

PrLion commented 4 years ago

@PrLion yeah. For my app on App Store, it worked because of the kill switch which is controlled remotely.

Now Either we have to wait for the FB team to reply and fix this or you can meanwhile upgrade and request for expedite release to the Apple team.

thx. Can you tell how can I do this one too?

Garima0812 commented 4 years ago

App is getting crashed since 11:45 in the morning due to the exception in FBSDK . Please resolve it as soon as possible .

agam-mahajan-swiggy commented 4 years ago

@PrLion After submitting app for review Go to this link https://developer.apple.com/contact/app-store/?topic=expedite and fill the necessary information. Mention the crash and the fix.

PrLion commented 4 years ago

@PrLion After submitting app for review Go to this link https://developer.apple.com/contact/app-store/?topic=expedite and fill the necessary information. Mention the crash and the fix.

Thank you)

OneManMobile commented 4 years ago

Is there a timeline for the rollout of a fix @joesus ?

wangjunhua1 commented 4 years ago

The old version suddenly appeared a lot of crashes today [FBSDKRestrictiveDataFilterManager updateFilters:restrictiveParams:]

image
alainnguyen commented 4 years ago

Same here on our iOS App on Live users, using FBSDK 5.1.1. Please, fix the regression ASAP.

matt-aitken commented 4 years ago

Same here. I believe this issue also happened on May 7!!

rom4ikq commented 4 years ago

Same here. Using FBSDK 5.0.2

danbus commented 4 years ago

The same problem, please fix it as soon as possible, affecting all users

samh-depop commented 4 years ago

We are using 5.2.3 and having the same crash. This is crashing the app for all our users in productions.

Can anyone help on this?

JamesSawley commented 4 years ago

Same problem on 5.11

IainS1986 commented 4 years ago

Same issue with SDK 5.0.2 (Xamarin package Xamarin.Facebook.iOS 5.0.2 etc)

Upgrading to SDK 5.12.0 (Xamarin package(s) Xamarin.Facebook.iOS 5.12.0 etc) seemed to resolve the issue.

PavloNovak commented 4 years ago

Same 5.6.0

th3hamm0r commented 4 years ago

Just tested a minor upgrade from 5.0 to 5.15.0, it worked for a couple of app-starts, but then started crashing again (so the SDK seems to update itself in some ways). So you will probably need a higher version, but I cannot tell at the moment, if that fixes the issue...

Related: https://github.com/facebook/facebook-ios-sdk/issues/1373#issuecomment-624936404

kopfnick commented 4 years ago

Multiple of our apps crashing for us, new releases are not an option. Spotify is also down...

esam091 commented 4 years ago

All essential apps in my country crashes ☹️

tecbot commented 4 years ago

Second time this year, great

guptameet commented 4 years ago

FBKMKB

guptameet commented 4 years ago

FB is not responsible enough to have shipped code like this. Irresponsible!!

Wisors commented 4 years ago

FB, Have you consider adding Continuous Integration and Functional Tests questions to your Interview's questionnaire?

Ravi61 commented 4 years ago

MoveFastBreakEverything

Do you even have a code review process?

tewner commented 4 years ago

We're seeing this issue too. This may be related to bug https://developers.facebook.com/support/bugs/249767556223451/ which was fixed back in May by a Facebook Platform rollback.

wangjunhua1 commented 4 years ago

Now there are problems with the new version

wangjunhua1 commented 4 years ago

Now there are problems with the new version

FBSDKCoreKit、FBSDKLoginKit、FBSDKShareKit 6.3.0

tothvoj-gl commented 4 years ago

Issue status here: https://developers.facebook.com/status/issues/1739188102911114/

soaurabhtokopedia commented 4 years ago

FB guys, any ETA around this fix, please...

nghuiqin commented 4 years ago

It's Happy Friday 🥇

objectiveCarlo commented 4 years ago

Anyone have eta? will they fix for all versions or just the newest version of their sdk?

arthur-watcha commented 4 years ago

@agam-mahajan-swiggy

How did you remotely control whether to use the SDK?

lawgimenez commented 4 years ago

Spotify, Booking.com and Pinterest crashing

iphonic commented 4 years ago

Happening all of a sudden crash in Development too..

-[NSNull count]: unrecognized selector sent to instance 0x10d05eea8

in FBSDKRestrictiveDataFilterManager

+ (void)updateFilters:(nullable NSDictionary<NSString *, id> *)restrictiveParams
{
  if (restrictiveParams.count > 0) {

Line number 62

simonlee2 commented 4 years ago

@PrLion yeah. For my app on App Store, it worked because of the kill switch which is controlled remotely. I disabled SDK when got crash alert.

Now Either we have to wait for the FB team to reply and fix this or you can meanwhile upgrade to latest SDK (try 7.1.1) and request for expedite release to the Apple team.

Also, add some kill switch for this SDK so that this kind of situation doesn't come again.

How did you disable the SDK?

PrLion commented 4 years ago

@PrLion

How did you remotely control whether to use the SDK?

I can't do it. "I'm not Steve Jobs)))". I'm confusion like you all) Just sent my application to update.

TimNN commented 4 years ago

While this doesn't help from the developer side of things, as a user I noticed that, for me, the Apps start in Airplane mode, although they crash as soon as Airplane mode is deactivated.

apchrkey commented 4 years ago

Thank you Facebook, for stopping everyone from using their phones.

apchrkey commented 4 years ago

Another reason to never put any Facebook code in your app?

rhysforyou commented 4 years ago

Yeah there's no way to implement a kill switch since the Facebook SDK swizzles methods to bootstrap itself when your app launches. If you include the Facebook SDK, you're trusting Facebook not to crash your app.

AleshaOleg commented 4 years ago

FB investigating - https://developers.facebook.com/support/bugs/329763701368293/