FBSDKCoreKit.framework: Unsealed contents present in the root directory of an embedded framework

bdaz commented 2 years ago

Checklist before submitting a bug report

[X] I've updated to the latest released version of the SDK
[X] I've searched for existing GitHub issues
[X] I've looked for existing answers on Stack Overflow, the Facebook Developer Community Forum and the Facebook Developers Group
[X] I've read the Code of Conduct
[X] This issue is not security related and can safely be disclosed publicly on GitHub

Xcode version

14.0

Facebook iOS SDK version

14.1.0

Dependency Manager

CocoaPods

SDK Framework

Core

Goals

The directory structure of FBSDKCoreKit.framework is invalid for an embedded framework, because FacebookSDKStrings.bundle is in the wrong place. This prevents macCatalyst builds when the app includes FBSDKCoreKit, because code signing will fail.

Simply moving FBSDKCoreKit/XCFrameworks/FBSDKCoreKit.xcframework/ios-arm64_x86_64-maccatalyst/FBSDKCoreKit.framework/FacebookSDKStrings.bundle to FBSDKCoreKit/XCFrameworks/FBSDKCoreKit.xcframework/ios-arm64_x86_64-maccatalyst/FBSDKCoreKit.framework/Versions/A/Resources/FacebookSDKStrings.bundle fixes this issue.

Expected results

You should be able to codesign the FBSDKCoreKit framework for macCatalyst without issue.

Actual results

/usr/bin/codesign --force --sign <abc>  --preserve-metadata=identifier,entitlements '/Users/bdaz/Library/Developer/Xcode/DerivedData/Thoughtful-cbuhkdrltepatyaqufbenzszbwvr/Build/Products/Debug-maccatalyst/Thoughtful.app/Contents/Frameworks/FBSDKCoreKit.framework'

/Users/bdaz/Library/Developer/Xcode/DerivedData/Thoughtful-cbuhkdrltepatyaqufbenzszbwvr/Build/Products/Debug-maccatalyst/Thoughtful.app/Contents/Frameworks/FBSDKCoreKit.framework: unsealed contents present in the root directory of an embedded framework

Steps to reproduce

Add FBSDKCoreKit as a dependency. In my case, I'm using Cocoapods.
Try to build your app for macCatalyst.

Code samples & details

No response

bdaz commented 1 year ago

This is still an issue, FYI! Really easy fix for you guys.

kesha-antonov commented 1 year ago

Thanks, it worked

boblepepeur commented 1 year ago

Please update the lib !

arshiacont commented 9 months ago

Wow! Can't believe this issue has been open for such long!!! Thanks for the workaround

andytriboletti commented 8 months ago

Still an issue. The workaround works.

facebook / facebook-ios-sdk