search

facebook / facebook-ios-sdk

Used to integrate the Facebook Platform with your iOS & tvOS apps.
https://developers.facebook.com/docs/ios
Other
7.73k stars 3.51k forks source link

Fix infinite recursion when enabling `.graphAPIDebugInfo` logging behavior #2245

Closed revolter closed 1 month ago

revolter commented 10 months ago

Thanks for proposing a pull request!

To help us review the request, please complete the following:

Pull Request Details

Fixes #2152.

Test Plan

romarealmreborn commented 8 months ago

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • [x] sign contributor license agreement
  • [ ] I've ensured that all existing tests pass and added tests (when/where necessary)
  • [x] I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • [ ] I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Fixes #2152.

Test Plan

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • [x] sign contributor license agreement
  • [ ] I've ensured that all existing tests pass and added tests (when/where necessary)
  • [x] I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • [ ] I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Fixes #2152.

Test Plan

romarealmreborn commented 7 months ago

ผู้

thisisthekap commented 4 months ago

Any chance this PR is getting some attention?

There is a small and easy to understand fix that fixes an actual production crash.

The community gave it to you. For free.

revolter commented 4 months ago

I fixed the conflict

revolter commented 1 week ago

@jjiang10, please reopen and merge this 🙏🏻