search

facebook / facebook-ios-sdk

Used to integrate the Facebook Platform with your iOS & tvOS apps.
https://developers.facebook.com/docs/ios
Other
7.8k stars 3.56k forks source link

Feature Request: Support App Privacy Manifest #2264

Open devssun opened 1 year ago

devssun commented 1 year ago

Checklist before submitting a feature request

Goals

Apple required App Privacy manifests until 2025. So Facebook SDK that contains an app privacy manifest must be signed. I would like to know when you adopt this change.

References https://developer.apple.com/videos/play/wwdc2023/10060/ https://developer.apple.com/news/?id=av1nevon https://developer.apple.com/app-store/user-privacy-and-data-use/ https://developer.apple.com/support/third-party-SDK-requirements/

Please check it out. Thanks!

Expected results

Add Privacy Manifest

Code samples & details

No response

LionWY commented 11 months ago

+1

allywuyi commented 11 months ago

Apple updated the third-party SDK requirements.

References https://developer.apple.com/support/third-party-SDK-requirements/

angelmic commented 10 months ago

+1

kelv1nq1an commented 10 months ago

+1

omarzl commented 10 months ago

Using a binary analyzer I found these are the "Required reasons API" symbols in the generated frameworks:

Used symbols in binary ./FBAEMKit.framework/FBAEMKit: NSUserDefaults Used symbols in binary ./FBSDKCoreKit.framework/FBSDKCoreKit: NSFileSystemFreeSize, NSFileSystemSize, NSUserDefaults Used symbols in binary ./FBSDKCoreKit_Basics.framework/FBSDKCoreKit_Basics: NSUserDefaults

Used symbols in binary ./FBSDKLoginKit.framework/FBSDKLoginKit: no symbols Used symbols in binary ./FBSDKShareKit.framework/FBSDKShareKit: no symbols Used symbols in binary ./FBSDKGamingServicesKit.framework/FBSDKGamingServicesKit: no symbols

kalsariyarahul commented 10 months ago

Privacy Manifest

https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api

https://developer.apple.com/support/third-party-SDK-requirements/

maurovc commented 10 months ago

Hi, are there any updates in terms of ETA we can be aware of as the Spring 2024 deadline comes closer?

Thanks!

lakshmankreditbee commented 9 months ago

Hi, when can we expect an update regarding this issue?

asa08 commented 9 months ago

+1

gtalwadkar commented 9 months ago

Any update on ETA for this changes? Apple Spring 2024 deadline is approaching.

kalsariyarahul commented 9 months ago

+1

BarisSenliol commented 9 months ago

+1

percival888 commented 9 months ago

+1

cberkeleyHutch commented 9 months ago

+1

tjmichaeldev commented 9 months ago

Punxsutawney Phil has predicted that Spring 2024 will be an early one, given that's Apple's deadline for compliance, is there any chance for an update regarding the status of privacy manifests for this SDK?

SergeyChereshnyuk commented 9 months ago

Hi Meta tema,

This is important for us too!

Apple has mandated that all third-party SDKs must include a privacy manifest and digital signature starting in spring 2024. We need to know when the new version of Facebook iOS SDK containing these features will be available. Can you let us know the version number and timeline from your end?

Thanks.

wlxo0401 commented 9 months ago

Apple has mandated that all third-party SDKs must include a privacy manifest and digital signature starting in spring 2024.

@SergeyChereshnyuk Digital signatures are not required by all third-party libraries.

I understand that the ones on the SDK list listed by Apple are compulsory for digital signatures.

Privacy Manifest is mandatory if you use an API that requires clarification, but I don't know if it's mandatory even if it's not..

Please give me your opinion if I'm wrong.

extstkim commented 8 months ago

Looks like it made it in via 3183c7eca8d71815818cf94948dc66352a89f20e. Just needs to be released

sylvia-tencent-wmt commented 8 months ago

Dear support team,

When will https://github.com/facebook/facebook-ios-sdk/commit/3183c7eca8d71815818cf94948dc66352a89f20e be released?

Thanks

a-aasthapoddar commented 8 months ago

+1

omarzl commented 8 months ago

The deadlines were published yesterday https://developer.apple.com/news/?id=3d8a9yyh

teejayhh commented 8 months ago

Looks like it made it in via 3183c7e. Just needs to be released

NSPrivacyCollectedDataTypes is empty in that commit, that doesnt seem right.

extstkim commented 8 months ago

Looks like it made it in via 3183c7e. Just needs to be released

NSPrivacyCollectedDataTypes is empty in that commit, that doesnt seem right.

FBSDKCoreKit has it

teejayhh commented 8 months ago

Looks like it made it in via 3183c7e. Just needs to be released

NSPrivacyCollectedDataTypes is empty in that commit, that doesnt seem right.

FBSDKCoreKit has it

Yep I see, til I that you can have multiple privacy manifest files. Sorry for that oversight :)

saristotelis commented 8 months ago

+1

andre-alves commented 8 months ago

Still missing privacy manifests for FBSDKLoginKit and FBSDKShareKit...

extstkim commented 8 months ago

@ryantobinmeta, @KylinChang Sorry to mention you, but the last two releases have not been git tagged nor published in the Releases page. Is version 17.0.0 out or going through testing? Thanks!

mammaiap commented 7 months ago

when will be the next release with "Privacy Manifest" feature? .. i am getting the warning from AppStoreConnect . is it possible to get the next release in March 2024?

Thanks & Regards

samcolak commented 7 months ago

This is the big change to privacy as of May 4th (by Apple)https://developer.apple.com/news/?id=3d8a9yyhOn 18. Mar 2024, at 12:19, Muthulingam @.***> wrote: when will be the next release with "Privacy Manifest" feature? .. i am getting the warning from AppStoreConnect . is it possible to get the next release in March 2024? Thanks & Regards

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

phongth7 commented 7 months ago

Sorry for mentioning you, @ryantobinmeta, @KylinChang I've been following this issue for a while and recently discovered that the FBSDKGamingServicesKit doesn't have privacy manifest files. Is something amiss or not required?

Thanks & Regards

mikemike396 commented 7 months ago

Looks like the PrivacyInfo.xcprivacy files do exist on main.

Commit: https://github.com/facebook/facebook-ios-sdk/commit/af20a8442d47fc9a6d580bb866932d1b866c66f0

Would it be possible to get a version bump so we don't have to point to main or a specific commit hash?

Parvinderjit commented 7 months ago

+1

devssun commented 7 months ago

Hello I updated to 17.0.0 but it occurred with error. How can I fix this? Failed to resolve dependencies Dependencies could not be resolved because no versions of 'facebook-ios-sdk' match the requirement 17.0.0..<18.0.0 and root depends on 'facebook-ios-sdk' 17.0.0..<18.0.0.

marcoboerner commented 7 months ago

Hello I updated to 17.0.0 but it occurred with error. How can I fix this? Failed to resolve dependencies Dependencies could not be resolved because no versions of 'facebook-ios-sdk' match the requirement 17.0.0..<18.0.0 and root depends on 'facebook-ios-sdk' 17.0.0..<18.0.0.

There is no tag/release for v17.x yet. If you need a version with the new Privacy Manifest, you'd have to use the main branch or a specific commit. See the answer from @mikemike396

mikemike396 commented 7 months ago

🚀 https://github.com/facebook/facebook-ios-sdk/blob/main/CHANGELOG.md#1700 🚀

extstkim commented 7 months ago

v17 release is out as @mikemike396 pointed out, but does this contain the signing that's required by Apple?

https://developer.apple.com/support/third-party-SDK-requirements/

angelmic commented 7 months ago

FBSDKTVOSKit also needed

ArturoLee commented 7 months ago

NSPrivacyAccessedAPICategorySystemBootTime should be included.

I ran deriveddata % grep -RHn "systemUptime" (https://forums.developer.apple.com/forums/thread/749049) and got:

Binary file ./Setgraph-bfiotivoqdmnksczywmtmehguubu/Index.noindex/Build/Products/Debug-iphoneos/FBSDKCoreKit.framework.dSYM/Contents/Resources/DWARF/FBSDKCoreKit matches Binary file ./Setgraph-bfiotivoqdmnksczywmtmehguubu/SourcePackages/artifacts/facebook-ios-sdk/FBSDKCoreKit/FBSDKCoreKit.xcframework/ios-arm64_x86_64-simulator/dSYMs/FBSDKCoreKit.framework.dSYM/Contents/Resources/DWARF/FBSDKCoreKit matches Binary file ./Setgraph-bfiotivoqdmnksczywmtmehguubu/SourcePackages/artifacts/facebook-ios-sdk/FBSDKCoreKit/FBSDKCoreKit.xcframework/ios-arm64_x86_64-maccatalyst/dSYMs/FBSDKCoreKit.framework.dSYM/Contents/Resources/DWARF/FBSDKCoreKit matches Binary file ./Setgraph-bfiotivoqdmnksczywmtmehguubu/SourcePackages/artifacts/facebook-ios-sdk/FBSDKCoreKit/FBSDKCoreKit.xcframework/ios-arm64/dSYMs/FBSDKCoreKit.framework.dSYM/Contents/Resources/DWARF/FBSDKCoreKit matches Binary file ./Setgraph-bfiotivoqdmnksczywmtmehguubu/Build/Products/Debug-iphoneos/FBSDKCoreKit.framework.dSYM/Contents/Resources/DWARF/FBSDKCoreKit matches Binary file ./Setgraph-bfiotivoqdmnksczywmtmehguubu/Build/Products/Debug-iphoneos/Setgraph.app.dSYM/Contents/Resources/DWARF/Setgraph matches

Sonali2921 commented 6 months ago

I am using Facebook core and login in my codebase, which version to use for both of these which includes privacy manifest file? Can anyone help?

devssun commented 6 months ago

I am using Facebook core and login in my codebase, which version to use for both of these which includes privacy manifest file? Can anyone help?

@Sonali2921 Did you update to 17.0.0 version?