facebook / facebook-ios-sdk

Used to integrate the Facebook Platform with your iOS & tvOS apps.
https://developers.facebook.com/docs/ios
Other
7.73k stars 3.5k forks source link

I want to updating Facebook SDK to 17.0.0 bug it is fail ,please update to 17.0.0 #2364

Open zhangwei5436 opened 1 month ago

zhangwei5436 commented 1 month ago

Checklist before submitting a bug report

Xcode version

15.2

Facebook iOS SDK version

17.0.0

Dependency Manager

CocoaPods

SDK Framework

Core

Goals

I want to updating Facebook SDK to 17.0.0 bug it is fail ,please update to 17.0.0

Expected results

I want to updating Facebook SDK to 17.0.0 bug it is fail ,please update to 17.0.0

Actual results

I want to updating Facebook SDK to 17.0.0 bug it is fail ,please update to 17.0.0

Steps to reproduce

I want to updating Facebook SDK to 17.0.0 bug it is fail ,please update to 17.0.0

Code samples & details

I want  to updating Facebook SDK to 17.0.0  bug  it is  fail ,please update  to 17.0.0
zhangwei5436 commented 1 month ago

I'm currently using Facebook SDK version 16.3.1 in my Swift project,but ,it don't include Privacy Manifests,please update 17.0.0

sjhkim commented 1 month ago

Apps uploaded to App Store Connect must be built with Xcode 15 for iOS 17, iPadOS 17, tvOS 17, or watchOS 10, starting April 29, 2024. quote link

Without this change app developers using facebook iOS sdk will not be able to update their apps in the app store after April 29th, 2024. Please fix.

MatyasKrizN commented 1 month ago

From what I gather looking at the repository, 17.0 is not pushed to Cocoapods specs repo and the podspec file doesn't even contain the privacy manifest in resources like it should.

Please look at all the other maintained projects on GitHub if you're not sure how to include it, but if this isn't fixed soon we'll be forced to remove the SDK from our project.

angelmic commented 1 month ago

FBSDKTVOSKit also need, please

zarghol commented 1 month ago

@MatyasKrizN I updated my Podfile, and could retrieve the 17.0 version, so it seems to be updated now.

doesn't even contain the privacy manifest in resources

It seems the pod contains the compiled version of the sdk as a xcframework, not directly the sources. I think it is the correct way to embed the privacy manifest, for compiled sdks, compared to sources pod that indeed needs to contain privacy manifest in resources of the pod, in order to add it at the compilation of the pod.