Increase SharePhotoContent photos limit to 10

facebook / facebook-ios-sdk

Used to integrate the Facebook Platform with your iOS & tvOS apps.

https://developers.facebook.com/docs/ios

Other

7.8k stars 3.56k forks source link

Increase SharePhotoContent photos limit to 10 #2469

Closed sebastiangrail closed 2 months ago

sebastiangrail commented 2 months ago

[x] sign contributor license agreement
[x] I've ensured that all existing tests pass and added tests (when/where necessary)
[ ] I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
[ ] I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

SLComposeViewController has a limit of 10 images for sharing to Facebook. This PR increases the limit imposed by FBSDKShareKit from 6 to 10 and clarifies the comment.

Test Plan

Test Plan: Updated the current tests to reflect the change.

sebastiangrail commented 2 months ago

@joesus Is there anything blocking this from being merged? Also, do you happen to know why Apple imposes a limit in the first place?

sebastiangrail commented 2 months ago

@ryantobinmeta @yuriy-tolstoguzov Could one of you please have a look at this PR?

yuriy-tolstoguzov commented 2 months ago

Thank you for the pull request! SLComposeViewController indeed ignores anything above 10 photos

facebook-github-bot commented 2 months ago

@yuriy-tolstoguzov has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 months ago

@yuriy-tolstoguzov merged this pull request in facebook/facebook-ios-sdk@b07933dd69a56cf7ac3cc793a331bf4dadb556d6.