facebook / facebook-java-business-sdk

Java SDK for Meta Marketing APIs
https://developers.facebook.com/docs/business-sdk
Other
402 stars 332 forks source link

BUG on logger assign #342

Closed matteobaccan closed 1 year ago

matteobaccan commented 3 years ago

Hi

I have correct a removed redundant assignment in CrashReporter.java. Set logger parameter now is correctly assigned to static variable

ciao matteo

facebook-github-bot commented 3 years ago

Hi @matteobaccan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

matteobaccan commented 3 years ago

Hi

Someone can check this commit?

All the best Matteo Baccan

matteobaccan commented 2 years ago

Hi

I have made this PR 12 months ago, without feedback.

Excuse me for the question: but is this repository maintained?

all the best matteo baccan

matteobaccan commented 1 year ago

Hi

I have fixed this error 20 month ago :) Someone can check it?

ciao matteo

facebook-github-bot commented 1 year ago

@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@stcheng merged this pull request in facebook/facebook-java-business-sdk@0f8f0c0fd108d488f445fcb7b99662ac57f9ee1e.