APIRequest<APINode> or APIRequest<AdSet> ?

facebook / facebook-java-business-sdk

Java SDK for Meta Marketing APIs

https://developers.facebook.com/docs/business-sdk

Other

395 stars 326 forks source link

APIRequest<APINode> or APIRequest<AdSet> ? #389

Closed wanqulou closed 1 year ago

wanqulou commented 2 years ago

https://github.com/facebook/facebook-java-business-sdk/blob/b815f20005b0f7236676793dbbaa404ac480e173/src/main/java/com/facebook/ads/sdk/AdAccount.java#L7312

kirsar commented 2 years ago

Hi, @wanqulou did you figure out proper creation flow for AdSet? Keeping in mind that it's not only base class returns from execute() but there's also some breaking changes in building methods of APIRequestCreateAdSet setBillingEvent(AdAccount.EnumBillingEvent billingEvent) vs setBillingEvent(AdSet.EnumBillingEvent billingEvent) ? Thanks!

kirsar commented 2 years ago

@wanqulou never mind, I made shallow research :) https://github.com/facebook/facebook-business-sdk-codegen/issues/41

wanqulou commented 2 years ago

Thanks @kirsar